Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getIsSomeRowsSelected on all selection #5499

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

iamswain25
Copy link

@iamswain25 iamswain25 commented Apr 19, 2024

Selecting all rows and run getIsSomeRowsSelected, it return false instead of true.

@iamswain25 iamswain25 force-pushed the fix/getIsSomeRowsSelected-on-all branch from 924383b to 1d9e4e7 Compare May 3, 2024 17:31
@sijonelis
Copy link

Is it possible to get this merged? The documentation already states that this is how the row selection check should work!

@@ -436,7 +436,7 @@ export const RowSelection: TableFeature = {
).length
return (
totalSelected > 0 &&
totalSelected < table.getFilteredRowModel().flatRows.length
totalSelected <= table.getFilteredRowModel().flatRows.length
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not the correct fix. We should just get rid of all the logic that returns false if all rows are selected.

@KevinVandy
Copy link
Member

To truly fix this I think some breaking changes might be needed. I'm going to point this PR to the alpha branch probably

Copy link

nx-cloud bot commented Jun 30, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a0f1cc3. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants